Add support for MetalLib contained in a Mach-O multi-architecture binary #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a new .metallib format present in at least macOS 14.0. This binary is accompanied by other GPU-specific binaries (likely as an optimization). The tool will also now output a warning in the theoretical scenario of the Mach-O binary containing GPU code but no MetalLib architecture.
|
Thank you so much! I didn't know these existed: I last looked at native shader binaries two years ago (https://github.com/zhuowei/AGXShaderExplorer), before they introduced precompiling to native. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new .metallib format present in at least macOS 14.0. This binary is accompanied by other GPU-specific binaries (likely as an optimization; maybe this Metal 3 feature?).
The code is not the best; probably the most code I've written at once in Python. I have successfully tested it with both the old .metallib format and the new Mach-O .metallib format. Let me know what you think of this PR.