Skip to content

Commit

Permalink
Revert of PPC/s390: SmiUntag only for 32bit (patchset #1 id:1 of http…
Browse files Browse the repository at this point in the history
…s://codereview.chromium.org/2842843005/ )

Reason for revert:
few tests are failing with stack overflow, will reland with the fix.

Original issue's description:
> PPC/s390: SmiUntag only for 32bit
>
> R=joransiu@ca.ibm.com, jyan@ca.ibm.com
> BUG=
> LOG=n
>
> Review-Url: https://codereview.chromium.org/2842843005
> Cr-Commit-Position: refs/heads/master@{#44908}
> Committed: https://chromium.googlesource.com/v8/v8/+/76dfdb7a32c4be41190ff6a01b23905976e5e0ff

TBR=joransiu@ca.ibm.com,jyan@ca.ibm.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2852433002
Cr-Commit-Position: refs/heads/master@{#44936}
  • Loading branch information
bjaideep authored and Commit bot committed Apr 27, 2017
1 parent 90e1ebe commit cef9eff
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
2 changes: 0 additions & 2 deletions src/builtins/ppc/builtins-ppc.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2208,9 +2208,7 @@ void Builtins::Generate_CallForwardVarargs(MacroAssembler* masm,
__ bind(&arguments_done);

Label stack_empty, stack_done, stack_overflow;
#if !V8_TARGET_ARCH_PPC64
__ SmiUntag(r3);
#endif
__ sub(r3, r3, r5);
__ cmpi(r3, Operand::Zero());
__ ble(&stack_empty);
Expand Down
2 changes: 0 additions & 2 deletions src/builtins/s390/builtins-s390.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2218,9 +2218,7 @@ void Builtins::Generate_CallForwardVarargs(MacroAssembler* masm,
__ bind(&arguments_done);

Label stack_empty, stack_done, stack_overflow;
#if !V8_TARGET_ARCH_S390X
__ SmiUntag(r2);
#endif
__ SubP(r2, r2, r4);
__ CmpP(r2, Operand::Zero());
__ ble(&stack_empty);
Expand Down

0 comments on commit cef9eff

Please sign in to comment.