Draft
Conversation
zifeif2
commented
Nov 24, 2025
| println("before decoding valueBytes size: ", valueBytes.length) | ||
| println("Platform.BYTE_ARRAY_OFFSET", Platform.BYTE_ARRAY_OFFSET) | ||
|
|
||
| val valueRow = new UnsafeRow(4) |
Owner
Author
There was a problem hiding this comment.
hard coded number of fields here for integration test
zifeif2
commented
Nov 24, 2025
| // The bytes are in UnsafeRow memory format from StatePartitionReaderAllColumnFamilies | ||
| keyRow.pointTo(keyBytes, Platform.BYTE_ARRAY_OFFSET, keyBytes.length) | ||
| val keyRow = new UnsafeRow(1) | ||
| keyRow.pointTo(keyBytes, Platform.BYTE_ARRAY_OFFSET, |
Owner
Author
There was a problem hiding this comment.
This is the part that I am not sure about - how to decode the bytes fetched from AllColumnFamiliesReader to an UnsafeRow, so that RocksDBStateStoreProvider can encode it to the correct format of Array[Byte] later?
zifeif2
commented
Nov 24, 2025
| .as[(Int, Long, Long, Int, Int)] | ||
|
|
||
| // check with more data - leverage full partitions | ||
| testStream(aggregated, OutputMode.Update)( |
Owner
Author
There was a problem hiding this comment.
Running some query on target src to make sure that when overwriting the partition, we won't read the previous store
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?