Merge pull request #24 from zifter/feature/use-unit-tests

Use unittest plugin

.github/workflows/github-chart-testing.yaml

@@ -1,7 +1,7 @@
 name: Run Helm Test Cases
 on: pull_request
 jobs:
-  Helm-Template-All:
+  Helm-Run-Tests:
     runs-on: ubuntu-latest
     steps:
       - name: Check out repository code
@@ -10,7 +10,9 @@ jobs:
       - name: Run Tests
         uses: WyriHaximus/github-action-helm3@v2
         with:
-          exec: ${{ github.workspace }}/dev/run-tests.sh
+          exec: |-
+            helm plugin install https://github.com/quintush/helm-unittest &&
+            /github/workspace/dev/run-tests.sh
 
   Helm-Lint:
     runs-on: ubuntu-latest

README.md

@@ -55,6 +55,13 @@ Install [https://github.com/karuppiah7890/helm-schema-gen](helm-schema-gen) spec
 helm plugin install https://github.com/karuppiah7890/helm-schema-gen.git
 ```
 
+#### Install helm-unittest
+Install [https://github.com/quintush/helm-unittest](helm-unittest) special plugin to test helm
+
+```bash
+helm plugin install https://github.com/quintush/helm-unittest
+```
+
 ### Launching test cluster with all dependencies
 ```bash
 ./dev/cluster/run.sh

charts/agones-dashboards/Chart.yaml

@@ -2,7 +2,7 @@ apiVersion: v2
 name: agones-dashboards
 description: A Helm chart of agones dashboards. Provide grafana dashboards.
 type: application
-version: 1.16.1
+version: 1.16.2
 appVersion: "1.16.0"
 icon: https://artifacthub.io/static/media/placeholder_pkg_helm.png
 home: https://github.com/googleforgames/agones

charts/agones-dashboards/tests/dashboards_test.yaml

@@ -0,0 +1,8 @@
+suite: test dashboards
+templates:
+  - dashboards.yaml
+tests:
+  - it: render by default
+    asserts:
+      - hasDocuments:
+          count: 1

charts/agones-dashboards/tests/template-all/values-full.yaml

@@ -1,99 +1,14 @@
 replicaCount: 1
 
-image:
-  repository: zifter/zookeeper_exporter
-  pullPolicy: IfNotPresent
-  tag: "latest"
-
-imagePullSecrets: []
 nameOverride: ""
 fullnameOverride: ""
 
-serviceAccount:
-  create: true
-  annotations: {}
-  name: ""
-
-podAnnotations: {}
-
-podSecurityContext:
-  fsGroup: 2000
-
-securityContext:
-   capabilities:
-     drop:
-     - ALL
-   readOnlyRootFilesystem: true
-   runAsNonRoot: true
-   runAsUser: 1000
-
-service:
-  type: ClusterIP
-  port: 80
-
-ingress:
-  enabled: false
-  className: ""
-  annotations:
-     kubernetes.io/ingress.class: nginx
-     kubernetes.io/tls-acme: "true"
-  hosts:
-    - host: chart-example.local
-      paths:
-        - path: /
-          pathType: ImplementationSpecific
-  tls:
-    - secretName: chart-example-tls
-      hosts:
-        - chart-example.local
-
-resources:
-   limits:
-     cpu: 100m
-     memory: 128Mi
-   requests:
-     cpu: 100m
-     memory: 128Mi
-
-nodeSelector: {}
-
-tolerations: []
-
-affinity: {}
-
-# Prometheus rules
-rules:
-  enabled: true
-
-# Grafana dashboards
-dashboards:
-  enabled: true
-  # Labels to add dashboard
-  labels:
-    # default grafana dashboard discovery label with stub value
-    # Override this value if you use custom grafana label
-    # https://github.com/grafana/helm-charts/blob/grafana-6.16.3/charts/grafana/values.yaml#L629
-    grafana_dashboard: '1'
-  # Folder to put dashboard in grafana
-  # Will be used default if it's empty
-  targetFolder: ""
-
-# Prometheus service monitor
-metrics:
-  enabled: true
-  # Interval between metrics scraping
-  interval: 1m
-
-# Kafka clusters to export metrics
-zookeeper:
-  - name: cluster1
-    # list of hosts of cluster to monitor
-    hosts:
-      - host1:2181
-      - host2:2181
-  - name: cluster2
-    # list of hosts of cluster to monitor
-    hosts:
-      - host1:2181
-      - host2:2181
-      - host2:2181
+# Labels to add dashboard
+labels:
+  # default grafana dashboard discovery label with stub value
+  # Override this value if you use custom grafana label
+  # https://github.com/grafana/helm-charts/blob/grafana-6.16.3/charts/grafana/values.yaml#L629
+  grafana_dashboard: '1'
+# Folder to put dashboard in grafana
+# Will be used default if it's empty
+targetFolder: ""