Add Buffer functions and fix misleading comments #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazeycode
approved these changes
Dec 1, 2024
| // `offset` has to be a multiple of 8 (otherwise `null` will be returned). | ||
| // `@sizeOf(T) * len` has to be a multiple of 4 (otherwise `null` will be returned). | ||
| // `offset` - in bytes, has to be a multiple of 8 (otherwise `null` will be returned). | ||
| // `len` - length of slice to return, in elements of type T, `@sizeOf(T) * len` has to be a multiple of 4 (otherwise `null` will be returned). |
There was a problem hiding this comment.
Thanks!
We should probably use doc-comments /// here so this gets displayed in users editors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've implemented several more functions in the zig Buffer interface, and modified a couple of comments that were confusing or incorrect.
Particularly, in mapAsync, size==0 will not map the entire buffer per the webgpu spec. If you call mapAsync with size=0, get[Const]MappedRange will always return null because any size to get will always be larger than the mapped range.
Source:
https://www.w3.org/TR/webgpu/#dom-gpubuffer-mapasync