Add bindings for OpenGL 4.3 core profile #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazeycode
reviewed
Nov 23, 2024
| pub const BUFFER = 0x82E0; | ||
| pub const SHADER = 0x82E1; | ||
| pub const PROGRAM = 0x82E2; | ||
| // pub const VERTEX_ARRAY = 0x8074; // already defined? |
There was a problem hiding this comment.
Yes this defined in OpenGL 1.1
hazeycode
approved these changes
Nov 23, 2024
|
I just noticed that I translated some const void* to [*c]const u8, while you do *anyopaque, will make a PR fixing that later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR advances #3.
This may be a bit big as a PR, but I don't know if breaking this up makes sense.
I cross-checked the constants twice, so I'm reasonably sure I didn't mess them up.
Everything is now ordered in the way it's listed in gl.xml