Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#523 PID scoped Accounts #530

Merged
merged 1 commit into from
Dec 29, 2023
Merged

#523 PID scoped Accounts #530

merged 1 commit into from
Dec 29, 2023

Conversation

Abdulbois
Copy link
Collaborator

Enable submitting PID ranges while adding account

@Abdulbois Abdulbois force-pushed the 523-PID-scopped-accounts branch 7 times, most recently from 9b7d36d to eb44a25 Compare December 25, 2023 14:11
@Abdulbois Abdulbois force-pushed the 523-PID-scopped-accounts branch from eb44a25 to 70e5464 Compare December 27, 2023 05:51
ashcherbakov
ashcherbakov reviewed Dec 27, 2023
View reviewed changes
proto/common/int32_range.proto Outdated Show resolved Hide resolved
x/dclauth/client/cli/tx_propose_add_account.go Outdated Show resolved Hide resolved
x/dclauth/types/message_propose_add_account.go Outdated Show resolved Hide resolved
x/dclauth/types/account.go Show resolved Hide resolved
x/dclauth/client/cli/tx_propose_add_account.go Outdated Show resolved Hide resolved
x/dclauth/handler_test.go Show resolved Hide resolved
docs/transactions.md Outdated Show resolved Hide resolved
docs/transactions.md Show resolved Hide resolved
@Abdulbois Abdulbois force-pushed the 523-PID-scopped-accounts branch from 70e5464 to 667fb95 Compare December 28, 2023 13:58
@Abdulbois Abdulbois force-pushed the 523-PID-scopped-accounts branch 2 times, most recently from 1196358 to eaa2747 Compare December 28, 2023 14:11
ashcherbakov
ashcherbakov approved these changes Dec 29, 2023
View reviewed changes
Copy link
Contributor

@ashcherbakov ashcherbakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Just a small comment #530 (comment) to be fixed.

@Abdulbois
#523 PID scoped Accounts
8445989 
Enable submitting PID ranges while adding account

Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>
Signed-off-by: Abdulbois <abdulbois123@gmail.com>
@Abdulbois Abdulbois force-pushed the 523-PID-scopped-accounts branch from eaa2747 to 8445989 Compare December 29, 2023 10:23
@akarabashov akarabashov merged commit b832e3c into master Dec 29, 2023
8 checks passed
@ashcherbakov ashcherbakov mentioned this pull request Jan 4, 2024
Closed
@akarabashov akarabashov deleted the 523-PID-scopped-accounts branch March 7, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akarabashov akarabashov akarabashov approved these changes

@ashcherbakov ashcherbakov ashcherbakov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Abdulbois @ashcherbakov @akarabashov