Require pyserial-asyncio newer than 0.5 #1131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Pipiche38/zigpy/fetchupstream02042022 (zigbeefordomoticz#1124) * merge zigpy and bellows upstream update * fix mistake in Version firmware deconding, whcih can impact the plugin startup * disable Log
* update readme with Windows page * update release date * make it Windows compatible Co-authored-by: Pipiche <pipiche38@users.noreply.github.com>
pyserial-asyncio is required by recommend use newer than pyserial-asyncio 0.5 (ie. 0.5 or later) as 0.5 is broken on Windows OS. Known issue with pyserial-asyncio 0.5 -> pyserial/pyserial-asyncio#69 https://github.com/zigbeefordomoticz/Domoticz-Zigbee/blob/stable6/requirements.txt See example [zigpy-znp](https://github.com/zigpy/zigpy-znp) config which exclude use of pyserial-asyncio 0.5 version : https://github.com/zigpy/zigpy-znp/blob/dev/setup.cfg ``` install_requires = pyserial-asyncio; platform_system!="Windows" pyserial-asyncio!=0.5; platform_system=="Windows" # 0.5 broke writes ```
|
please do submit PR against beta6 (and not stable6). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyserial-asyncio is required by recommend newer than pyserial-asyncio 0.5 (ie. 0.6 or later) as 0.5 is broken on Windows OS.
Due to known issue with pyserial-asyncio 0.5 on Windows OS -> pyserial/pyserial-asyncio#69
https://github.com/zigbeefordomoticz/Domoticz-Zigbee/blob/stable6/requirements.txt
See example zigpy-znp config which exclude use of pyserial-asyncio 0.5 version :
https://github.com/zigpy/zigpy-znp/blob/dev/setup.cfg
Alternative is to just set pyserial-asyncio 0.6 as the requirement, that is what Home Assistant core does for ZHA component:
https://github.com/home-assistant/core/blob/dev/requirements_all.txt#L1784