Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require pyserial-asyncio newer than 0.5 #1132

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

Hedda
Copy link
Contributor

@Hedda Hedda commented Apr 11, 2022

pyserial-asyncio is required by recommend newer than pyserial-asyncio 0.5 (ie. 0.6 or later) as 0.5 is broken on Windows OS.

Due to known issue with pyserial-asyncio 0.5 on Windows OS -> pyserial/pyserial-asyncio#69

https://github.com/zigbeefordomoticz/Domoticz-Zigbee/blob/stable6/requirements.txt

See example zigpy-znp config which exclude use of pyserial-asyncio 0.5 version :

https://github.com/zigpy/zigpy-znp/blob/dev/setup.cfg

install_requires =
    pyserial-asyncio; platform_system!="Windows"
    pyserial-asyncio!=0.5; platform_system=="Windows"  # 0.5 broke writes

Alternative is to just set pyserial-asyncio 0.6 as the requirement, that is what Home Assistant core does for ZHA component:

https://github.com/home-assistant/core/blob/dev/requirements_all.txt#L1784

# homeassistant.components.serial
# homeassistant.components.zha
pyserial-asyncio==0.6

Require pyserial-asyncio newer than 0.5
@pipiche38
Copy link
Collaborator

Thanks very much

@pipiche38 pipiche38 merged commit 66e1909 into zigbeefordomoticz:beta6 Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants