Treap: do not set key to undefined in remove to allow re-use of rem…

…oved nodes
ziglang · Oct 3, 2023 · 42ae395 · 42ae395
1 parent 40409c8
commit 42ae395
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 3 deletions.
diff --git a/lib/std/heap/general_purpose_allocator.zig b/lib/std/heap/general_purpose_allocator.zig
@@ -913,8 +913,6 @@ pub fn GeneralPurposeAllocator(comptime config: Config) type {
  // save the node for destruction/insertion into in empty_buckets
  var node = entry.node.?;
  entry.set(null);
- // restore the node's key since Treap.remove sets it to undefined
- node.key = bucket;
  if (self.cur_buckets[bucket_index] == bucket) {
  self.cur_buckets[bucket_index] = null;
  }

diff --git a/lib/std/treap.zig b/lib/std/treap.zig
@@ -225,7 +225,6 @@ pub fn Treap(comptime Key: type, comptime compareFn: anytype) type {
  link.* = null;
 
  // clean up after ourselves
- node.key = undefined;
  node.priority = 0;
  node.parent = null;
  node.children = [_]?*Node{ null, null };