Misc fixes #14333
Merged
Misc fixes #14333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vexu
force-pushed
the
fixes
branch
3 times, most recently
from
ad79774 to
6b6523b
Compare
|
Thanks! It's working now in release fast. |
This matches stage1 behavior. Closes ziglang#14322
These attributes can appear in any order but AstGen expects the source cursor to be incremented in a monotonically increasing order. Closes ziglang#14332
The undef pointer ended up being zero on wasm32.
Line comments do not produce actual tokens so they need special handling for null bytes. Closes ziglang#14346
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@star-tek-mb if you can try building master with the Windows C ABI commit applied to see if it fixes the issues you're seeing.