Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std.hash.crc: implement algorithms listed in CRC RevEng catalog #14396

Merged
merged 3 commits into from
Jan 22, 2023

Conversation

FnControlOption
Copy link
Contributor

Based on https://github.com/mrhooray/crc-rs and https://github.com/akhilles/crc-catalog

XZ decompression (#2851) requires CRC-64/XZ in particular

I originally intended to write update_crc_catalog.sh in Zig, but the stdlib doesn't yet support the SSL certificate at https://reveng.sourceforge.io/crc-catalogue/all.htm

Copy link
Member

@andrewrk andrewrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

I originally intended to write update_crc_catalog.sh in Zig, but the stdlib doesn't yet support the SSL certificate at https://reveng.sourceforge.io/crc-catalogue/all.htm

I want to enforce the rule of tools/* being zig code. I opened #14406 to track the SSL certificate issue. How about this compromise for now: the data at https://reveng.sourceforge.io/crc-catalogue/all.htm is provided as an input file to the .zig script, which can take it from there.

I would also like to request that the tests go into a separate file whose filename ends in "test.zig" which will cause it to be excluded from the set of installed files. This is a small optimization to keep zig's installation size down.

@FnControlOption
Copy link
Contributor Author

a separate file whose filename ends in "test.zig" which will cause it to be excluded from the set of installed files. This is a small optimization to keep zig's installation size down.

I didn't know blank_extensions existed, that's cool!

@andrewrk andrewrk enabled auto-merge January 22, 2023 18:41
@andrewrk andrewrk merged commit 4133bbd into ziglang:master Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants