Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the CACHEDIR.TAG file to the cache directory #14875

Closed
wants to merge 2 commits into from

Conversation

perillo
Copy link
Contributor

@perillo perillo commented Mar 10, 2023

Implement the http://www.brynosaurus.com/cachedir/ specification for the Zig cache directory.

This change will make it easier to exclude Zig cached data from a backup, expecially when the directory is not a well-known cache directory, like ~/.cache/zig or zig-cache.

Closes #8210

Implement the http://www.brynosaurus.com/cachedir/ specification for the
Zig cache directory.

This change will make it easier to exclude Zig cached data from a backup,
expecially when the directory is not a well-known cache directory, like
~/.cache/zig or zig-cache.

Closes ziglang#8210
@perillo
Copy link
Contributor Author

perillo commented Mar 11, 2023

For @r00ster91: I don't why I don't see your comment here (maybe you deleted it?).
I used the link http://www.brynosaurus.com/cachedir/ instead of the actual link after a redirect (https://bford.info/cachedir/) because this is what the specification suggested.

While it is true that the specification has not been updated since 2004, some implementations like Kopia use the original link.

@perillo
Copy link
Contributor Author

perillo commented Mar 11, 2023

On Linux the CI scripts fail with unimplemented. I'm not sure if this is related to this changeset.

@Vexu Vexu enabled auto-merge (squash) March 23, 2023 14:47
@perillo
Copy link
Contributor Author

perillo commented Mar 24, 2023

The error from the CI is

[15/21] Running zig1.wasm to produce /home/ci/actions-runner1/_work/zig/zig/build-new/compiler_rt.c
FAILED: compiler_rt.c 
cd /home/ci/actions-runner1/_work/zig/zig && /home/ci/actions-runner1/_work/zig/zig/build-new/zig1 /home/ci/actions-runner1/_work/zig/zig/lib build-obj lib/compiler_rt.zig -ofmt=c -OReleaseSmall --name compiler_rt -femit-bin="/home/ci/actions-runner1/_work/zig/zig/build-new/compiler_rt.c" --mod build_options::/home/ci/actions-runner1/_work/zig/zig/build-new/config.zig --deps build_options -target x86_64-linux
unimplemented
Aborted
[16/21] Running zig1.wasm to produce /home/ci/actions-runner1/_work/zig/zig/build-new/zig2.c
FAILED: zig2.c 
cd /home/ci/actions-runner1/_work/zig/zig && /home/ci/actions-runner1/_work/zig/zig/build-new/zig1 /home/ci/actions-runner1/_work/zig/zig/lib build-exe src/main.zig -ofmt=c -lc -OReleaseSmall --name zig2 -femit-bin="/home/ci/actions-runner1/_work/zig/zig/build-new/zig2.c" --mod build_options::/home/ci/actions-runner1/_work/zig/zig/build-new/config.zig --deps build_options -target x86_64-linux
unimplemented

Should the tagCacheDirectory function be a no op when the target is wasm?

Thanks.

@andrewrk
Copy link
Member

@Vexu I don't think this should be merged as-is because it should not block the rest of the compilation pipeline. I think it should be done as an asynchronous job that gets completed by performAllTheWork().

Anyway, closing this now since it's an abandoned PR that never passed the CI checks. @perillo can ask for help in the issue corresponding to this PR. I like to keep the PR queue filled with only patches that are considered ready for review & merge by their authors.

@andrewrk andrewrk closed this Jun 17, 2023
auto-merge was automatically disabled June 17, 2023 23:40

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add CACHEDIR.TAG to zig-cache
2 participants