Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement access and faccessat with W_OK on Windows #15697

Closed
wants to merge 2 commits into from
Closed

Implement access and faccessat with W_OK on Windows #15697

wants to merge 2 commits into from

Conversation

notcancername
Copy link
Sponsor Contributor

No description provided.

@notcancername @andrewrk
Implement access and faccessat with W_OK on Windows
2156197 
`windows.GetFileAttributesW` seems to already handle the errors
checked for in `accessW`.
andrewrk
andrewrk requested changes Jul 25, 2023
View reviewed changes
lib/std/c/windows.zig Outdated Show resolved Hide resolved
andrewrk
andrewrk requested changes Oct 19, 2023
View reviewed changes
Copy link
Member

@andrewrk andrewrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding logic to the posix compatibility layer, I think you should add support for these in std.fs.Dir.accessW.

related:

@notcancername
Copy link
Sponsor Contributor Author

Closing as I am not personally invested enough here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewrk andrewrk andrewrk requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notcancername @andrewrk