Add missing errors to @ptrFromInt and calling convention validation
#20084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vexu
force-pushed
the
missing-errors
branch
2 times, most recently
from
7148717 to
e96dca0
Compare
mlugg
approved these changes
Jun 2, 2024
src/Sema.zig
Outdated
| } | ||
| if (try sema.typeRequiresComptime(ptr_ty)) { | ||
| return sema.failWithOwnedErrorMsg(block, msg: { | ||
| const msg = try sema.errMsg(block, src, "cannot get a runtime pointer to comptime-only type '{}'", .{ptr_ty.fmt(mod)}); |
There was a problem hiding this comment.
Suggested change
| const msg = try sema.errMsg(block, src, "cannot get a runtime pointer to comptime-only type '{}'", .{ptr_ty.fmt(mod)}); | |
| const msg = try sema.errMsg(block, src, "pointer to comptime-only type '{}' must be comptime-known, but operand is runtime-known", .{ptr_ty.fmt(mod)}); |
There was a problem hiding this comment.
It's a bit verbose but I do like it better.
| // error | ||
| // target=native | ||
| // | ||
| // :5:54: error: cannot get a runtime pointer to comptime-only type '?*tmp.GuSettings' |
There was a problem hiding this comment.
(this line needs changing too under the above suggestion)
andrewrk
pushed a commit
that referenced
this pull request
Jun 6, 2024
Add missing errors to `@ptrFromInt` and Signal calling convention validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.