-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
loongarch: add glibc start.S to make zig-bootstrap work for loongarch64-linux-gnu #21015
Conversation
That's odd; I definitely updated the start files in #20993. Hmm... |
This fix is in LLVM 19; we also need it for RISC-V. |
Ok, I see what went wrong. The update procedure doesn't document the fact that start files for new architectures need to be added by hand. However, I believe we might need some more headers:
It's not actually clear to me why we're duplicating these between
I think you placed it correctly, but just to be sure, I'll build glibc for |
Yes, it's correct; it doesn't get installed to So, just need the extra headers I mentioned above and this should be good to go. |
start.S
andregdef.h
are from glibc 2.40.Current LLVM 18 does not support
.cfi_label
yet instart.S
.We need this in LLVM to make this code work in zig-bootstrap.
llvm/llvm-project#97922
Also, I'm not sure whether I should put the
regdef.h
file the path here in this patch or should put it atlib/libc/include/loongarch64-linux-gnu/sys