-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
std.Target
: Rewrite DynamicLinker.standard() and fill in some missing details.
#21037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrp
force-pushed
the
target-dyld
branch
2 times, most recently
from
August 13, 2024 03:38
d02cd6c
to
4d9fc0a
Compare
linusg
reviewed
Aug 13, 2024
alexrp
force-pushed
the
target-dyld
branch
4 times, most recently
from
August 16, 2024 05:55
6215e47
to
34f1726
Compare
alexrp
force-pushed
the
target-dyld
branch
2 times, most recently
from
August 28, 2024 00:57
ea47605
to
81cbb64
Compare
alexrp
force-pushed
the
target-dyld
branch
2 times, most recently
from
September 3, 2024 15:51
0af24ba
to
2194966
Compare
linusg
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good TODO comments 👍
alexrp
force-pushed
the
target-dyld
branch
3 times, most recently
from
September 24, 2024 07:08
9e57962
to
55c51e7
Compare
|
Will address these after merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went and collected all the known dynamic linker paths from GCC, Clang, and a few other places online, and then rewrote this function. Also moved some OS prongs for which I concluded with a reasonable degree of confidence that the OS doesn't have a standard dynamic linker path.
Recommend reviewing this one by just looking at the new implementation rather than the diff.
(Almost all of the ABI-related TODOs I'm adding here can be addressed by #20690.)