-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
std: update std.builtin.Type
fields to follow naming conventions
#21225
Conversation
Probably for the best. This had been bugging me forever! |
3200864
to
aaa7e73
Compare
The compiler actually doesn't need any functional changes for this: Sema does reification based on the tag indices of `std.builtin.Type` already! So, no zig1.wasm update is necessary. This change is necessary to disallow name clashes between fields and decls on a type, which is a prerequisite of ziglang#9938.
These won't live in the parent namespace as decls which causes problems later in this function, and tests are guaranteed not to be referenced at comptime anyway, so there's actually no need to run this logic.
@andrewrk I'm confident that the changes are correct, but idk if you want to look this over anyway. Perhaps just double-check that the field names in |
Looks good. It makes sense for result of reflection to use the same names as the types. |
rather tedious to have to support both naming styles
rather tedious to have to support both naming styles
Release Notes
|
What can I say? I just felt like breaking everyone's code this release cycle.
This is a prerequisite for a minor language change (disallowing fields and declarations with the same name) which is itself a prerequisite of #9938.