Sema: disallow unsafe in-memory coercions #22243
Merged
+279
−144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlugg
force-pushed
the
better-imc
branch
3 times, most recently
from
ba3a57b to
62825c0
Compare
The error messages here aren't amazing yet, but this is an improvement on status quo, because the current behavior allows false negative compile errors, so effectively miscompiles. Resolves: ziglang#15874
The previous commit exposed some missing `const` qualifiers in a few places. These mutable slices could have been used to store invalid values into memory!
And change corresponding signature in `DarwinPosixSpawn`.
andrewrk
reviewed
Dec 16, 2024
test/cases/compile_errors/use_implicit_casts_to_assign_null_to_non-nullable_pointer.zig
Show resolved
Hide resolved
mlugg
added
the
breaking
|
This is technically breaking, but I'm unsure if it should have release notes or not, since the breakage is fairly minor -- the most common case will just be a missing |
|
I think it's worth a note - you had to fix some pointer types in DarwinPosixSpawn.zig after all - and that might not be obvious to users without a mention it the release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error messages here aren't amazing yet, but this is an improvement on status quo, because the current behavior allows false negative compile errors, so effectively miscompiles.
Resolves: #15874