incremental: bugfixes #22379
Merged
incremental: bugfixes #22379
+112
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wooster0
reviewed
Jan 1, 2025
Previously, logic in `Compilation.getAllErrorsAlloc` was corrupting the `failed_analysis` hashmap. This meant that on updates after the initial update, attempts to remove entries from this map (because the `AnalUnit` in question is being re-analyzed) silently failed. This resulted in compile errors from earlier updates wrongly getting "stuck", i.e. never being removed. This commit also adds a few log calls which helped me to find this bug.
mlugg
force-pushed
the
incremental-fixes
branch
from
118b228 to
f0d5e0d
Compare
|
Nice, looking forward to trying it out again :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few bugs with incremental compilation. The first tripped an assert in some cases (although didn't actually affect ReleaseFast compilers in practice AFAICT), while the second was a much more significant bug. The bug in question was that while collecting error bundles, we corrupted the state of
Zcu.failed_analysison the false assumption that we would never use it again. That meant that when future incremental updates tried to remove elements from the map (because the correspondingAnalUnitwas undergoing re-analysis), the error wasn't found by the lookup, causing it to persist forever.@andrewrk, this bug absolutely explains why we have consistently been having issues with incremental compilation when trying to use
-Dno-bin -fincremental --watchfor e.g. big compiler changesets. Because ofstd.ArrayHashMapUnmanaged(...).linear_scan_max, this bug did not manifest on small test cases (i.e. every case intest/incremental/!), but did manifest very nastily once you exceeded 8 compile errors. After this is merged, I'd encourage you to give incremental another go!