Handle implicit casts in translate-c #2296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LemonBoy
force-pushed
the
translate-c-stuff
branch
2 times, most recently
from
846cea1
to
6336110
Compare
andrewrk
approved these changes
Apr 21, 2019
src/translate_c.cpp
Outdated
| // - Fold the comparison iif the value is either 0/1 | ||
| // - Don't fold the comparison (this generates awkward code such | ||
| // as 1 != 0 for true or 0 != 0 for false | ||
| #if 0 |
There was a problem hiding this comment.
I like the "always try to constant-fold the comparison". I don't really see any downsides to it, do you?
There was a problem hiding this comment.
I like the "always try to constant-fold the comparison"
Done!
I don't really see any downsides to it, do you?
Folding everything "erases" the constant value coming from the C code, but that's not much of a problem, I guess.
LemonBoy
force-pushed
the
translate-c-stuff
branch
from
6336110
to
70c2e86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review carefully and check out the
XXX