Minor fix for Allocator.remap and mem.bytesAsSlice for zero-sized types
#23220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alichraghi
approved these changes
Mar 18, 2025
|
Can you please squash the relevant parts of be1acb6 into the two prior commits? |
samy-00007
force-pushed
the
bytesAsSlice-fix
branch
from
be1acb6 to
7ecd10c
Compare
|
Like that ? |
|
I meant to split it up and amend the relevant formatting fixes into the two previous commits, since it's fixing formatting in both. |
also added a test for json parsing of zero sized type
samy-00007
force-pushed
the
bytesAsSlice-fix
branch
from
7ecd10c to
4595b1e
Compare
|
Oh sorry, should be good now. |
alexrp
added a commit
that referenced
this pull request
Mar 25, 2025
Minor fix for `Allocator.remap` and `mem.bytesAsSlice` for zero-sized types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 3 things:
Allocator.remap, if the type is zero-sized, then it only changes the slice's lengthmem.bytesAsSlice, if the type is zero-sized, it returns a slice with a length of zero (instead of crashing because of a division by zero)Fixes #23168