New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fix for `Allocator.remap` and `mem.bytesAsSlice` for zero-sized types #23220

Open

samy-00007 wants to merge 3 commits into ziglang:master from samy-00007:bytesAsSlice-fix

Contributor

samy-00007 commented Mar 12, 2025

This PR does 3 things:

for Allocator.remap, if the type is zero-sized, then it only changes the slice's length
for mem.bytesAsSlice, if the type is zero-sized, it returns a slice with a length of zero (instead of crashing because of a division by zero)
added a test for the 2 first points and one for json parsing with zero-sized types

Fixes #23168

samy-00007 added 3 commits

March 12, 2025 23:37


          fix: Allocator.remap now handles zero-bytes sized types

080393a


          std.mem.bytesAsSlice: fix to support zero-bytes sized types and added

1e225d3

tests


          fix fmt

be1acb6

alexrp added this to the 0.14.1 milestone

alichraghi approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet