Sema: convert slice sentinel to single pointer correctly #23221
+20
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rexicon226
force-pushed
the
comptime-memcpy-fix
branch
from
39bc17f to
09cbba3
Compare
Rexicon226
force-pushed
the
comptime-memcpy-fix
branch
from
09cbba3 to
cbcd772
Compare
|
Is this a 0.14.1 candidate? (i.e. a non-breaking bug fix) |
|
This is nonbreaking, these types never leave the implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
src_tyis a[:0]const u8, the single pointer would try to inherit the sentinel, which is invalid. I've fixed it to move the sentinel to the child type, if there is one, and then clear the sentinel from the pointer info we're inheriting.