build: allow overriding RSS limit for zig binary manually #23254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The max-RSS value had been bumped for several times during the 0.14.0 release cycle, showing that the current value is very close to the average RSS usage, with few redundant space. This adds a new option to specify the RSS upper bound for compiling Zig executable file. On AOSC OS, Zig 0.14.0 (& 0.13.0) fails to build on AArch64 and RISC-V 64, even when there are enough memory available on the build server. I have not found a minimal repro for this, but compilation does failed when all default settings of AOSC OS were applied. https://buildit.aosc.io/logs/72701-zig-0.14.0-riscv64-Estelle-buildit2-2025-03-15-03:47:45.txt https://buildit.aosc.io/logs/72698-zig-0.14.0-arm64-Zinfandel-2025-03-14-15:27:52.txt Signed-off-by: Bingwu Zhang <xtex@aosc.io>
xtexx
added a commit
to AOSC-Dev/aosc-os-abbs
that referenced
this pull request
Mar 15, 2025
- Update to 0.14.0 - Relax RSS upper bound for ARM64 and RISC-V 64 ziglang/zig#23254 Co-authored-by: 白铭骢 (Mingcong Bai) (@MingcongBai) <jeffbai@aosc.io>
3 tasks
xtexx
added a commit
to AOSC-Dev/aosc-os-abbs
that referenced
this pull request
Mar 15, 2025
- Update to 0.14.0 - Relax RSS upper bound for ARM64 and RISC-V 64 ziglang/zig#23254 Co-authored-by: 白铭骢 (Mingcong Bai) (@MingcongBai) <jeffbai@aosc.io>
MingcongBai
added a commit
to AOSC-Dev/aosc-os-abbs
that referenced
this pull request
Mar 17, 2025
- Update to 0.14.0 - Relax RSS upper bound for ARM64 and RISC-V 64 ziglang/zig#23254 Co-authored-by: 白铭骢 (Mingcong Bai) (@MingcongBai) <jeffbai@aosc.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The max-RSS value had been bumped for several times during the 0.14.0 release cycle, showing that the current value is very close to the average RSS usage, with few redundant space.
This adds a new option to specify the RSS upper bound for compiling Zig executable file.
On AOSC OS, Zig 0.14.0 (& 0.13.0) fails to build on AArch64 and RISC-V 64, even when there are enough memory available on the build server.
I have not found a minimal repro for this, but compilation does failed when all default settings of AOSC OS were applied.
https://buildit.aosc.io/logs/72701-zig-0.14.0-riscv64-Estelle-buildit2-2025-03-15-03:47:45.txt https://buildit.aosc.io/logs/72698-zig-0.14.0-arm64-Zinfandel-2025-03-14-15:27:52.txt