-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
std.zon.parse: add parsing of enum literals as string #23261
base: master
Are you sure you want to change the base?
Conversation
62c1be0
to
2b54435
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea.
My only suggested change is to rename enum_literals_as_string
-> enum_literals_as_strings
, other than that LGTM!
(Appreciate the tests covering |
Co-authored-by: Mason Remaley <MasonRemaley@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hi @MasonRemaley ,
great job at
std.zon
!to fully parse the new
build.zig.zon
schema's name field at runtime, we do not know the complete enum types,so instead we could enable parsing those fields into slices.
For Example this type:
can represent this ZON: