-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(std/fs): add support to parse home directory from /etc/passwd #23295
Open
jobansd
wants to merge
5
commits into
ziglang:master
Choose a base branch
from
jobansd:feature/read-home-dir-from-passwd
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+106
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented the TODO in `get_app_data_dir.zig` that suggests parsing the home directory from `/etc/passwd`.
IMO the getHomeDirFromPasswd() catch return error.AppDataDirUnavailable so something like const home_dir = posix.getenv("HOME") orelse (getHomeDirFromPasswd() catch return error.AppDataDirUnavailable); or const home_dir = posix.getenv("HOME") orelse blk: {
break :blk getHomeDirFromPasswd() catch return error.AppDataDirUnavailable;
}; |
Restored `GetAppDataDirError` error set in return type.
@squeek502, thanks for the suggestion, the change has been pushed. |
0d2af2a
to
53d2777
Compare
squeek502
reviewed
Mar 19, 2025
squeek502
reviewed
Mar 19, 2025
Moved `std.os.linux.getuid()` call out of the while loop to reduce invocations and created variable `currentUid` to store the value.
Changed fields in ReaderState enum to snake_case.
squeek502
reviewed
Mar 19, 2025
Replaced `std.os.linux.getuid()` with `std.posix.getuid()` and added supporting changes to enhance portability of `getHomeDirFromPasswd()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the TODO in
get_app_data_dir.zig
that suggests parsing the home directory from/etc/passwd
.Changes
getHomeDirFromPasswd()
function, which implements the parsing logic.Changed the return type ofgetAppDataDir()
fromGetAppDataDirError![]u8
to![]u8
to encompass errors fromfs.openFileAbsolute()
andreader.read()
GetAppDataDirError
retained in return type, updated thegetHomeDirFromPasswd()
function call to catch and returnerror.AppDataDirUnavailable
instead (suggested by @squeek502).getuid()
toc.zig
.getuid()
toposix.zig
.std.os.linux.getuid()
tostd.posix.getuid()
inget_app_data_dir.zig
.