std.Io: delete GenericWriter, AnyWriter, and null_writer #25036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewrk
added
breaking
|
I'll work on updating |
andrewrk
force-pushed
the
GenericWriter
branch
4 times, most recently
from
54f711d to
7f0e17d
Compare
These are some hastily made, untested changes to get things compiling again, since Ryan is working on a better upgrade patchset in the meantime.
perhaps these APIs have the defaults backwards, eh?
tracked by #25067 and I already have a fix cooking in another branch
I didn't notice the check+swap before.
andrewrk
force-pushed
the
GenericWriter
branch
from
7f0e17d to
7da9e4b
Compare
There was some bug in this branch, and rather than diagnosing it, I fully finished porting over to new Reader API. Did it fix the bug?
andrewrk
force-pushed
the
GenericWriter
branch
from
94bdf05 to
43fbc37
Compare
This was referenced Aug 29, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #24329.
Also delete some delimiter methods from GenericReader.
These things were all deprecated in favor of the new concrete Reader and Writer APIs.