fuzzing: implement limited fuzzing #25342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the limit option to `--fuzz=[limit]`. the limit expresses a number of iterations that *each fuzz test* will perform at maximum before exiting. The limit argument supports also 'K', 'M', and 'G' suffixeds (e.g. '10K'). Does not imply `--web-ui` (like unlimited fuzzing does) and prints a fuzzing report at the end. Closes #22900 but does not implement the time based limit, as after internal discussions we concluded to be problematic to both implement and use correctly.
kristoff-it
force-pushed
the
fuzz-limit
branch
from
d84a078 to
0feacc2
Compare
linusg
reviewed
Sep 24, 2025
andrewrk
requested changes
Sep 25, 2025
Member
andrewrk
left a comment
andrewrk
left a comment
There was a problem hiding this comment.
I didn't get a chance to look at the fuzzer lib changes yet but I think the requested changes to test runner are important enough they should be fixed before moving forward with this.
I'm happy to help with this
Comment on lines
+800
to
+801
| f.start(); | ||
| f.waitAndPrintReport(); |
Member
There was a problem hiding this comment.
Fine for this branch, but noting for any contributors watching this PR: a future enhancement will be to make fuzzing limited mode be part of the main build graph pipeline. In other words, limited mode fuzzing should run at the same time as the rest of the build.
kristoff-it
force-pushed
the
fuzz-limit
branch
from
c3a0246 to
9bb0b43
Compare
andrewrk
approved these changes
Sep 25, 2025
Member
andrewrk
left a comment
andrewrk
left a comment
There was a problem hiding this comment.
Looks ready to land - thanks for the changes!
--debug-rt previously would make rt libs match the root module. Now they are always debug when --debug-rt is passed. This includes compiler-rt, fuzzer lib, and others.
This would cause the web ui to crash in js or wasm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the limit option to
--fuzz. the limit expresses a number of iterations that each fuzz test will perform at maximum before exiting. The limit argument supports also 'K', 'M', and 'G' suffixes (e.g. '10K').Does not imply
--webui(like unlimited fuzzing does) and prints a fuzzing report at the end.Closes #22900 but does not implement the time based limit, as after internal discussions we concluded to be problematic to both implement and use correctly.