std.debug: add s390x-linux unwind support
#25443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er option This is a little different from how C/C++ compilers do this, but I think it's justified because it's what users actually *mean* when the use frame pointer options. This is another one of those LLVM "CPU" features that have nothing to do with CPU at all and should really be a TargetMachine option or something. One day we'll figure out a better way of dealing with these...
Makes FP-based unwinding work.
The old one was correct in terms of layout but very user-hostile.
rootbeer
reviewed
Oct 3, 2025
| pub fn dwarfRegisterBytes(ctx: *S390x, register_num: u16) DwarfRegisterError![]u8 { | ||
| switch (register_num) { | ||
| 0...15 => return @ptrCast(&ctx.r[register_num]), | ||
| // Why??? |
There was a problem hiding this comment.
This comment is really underselling the mess below! Its floating point registers, but also they're not stored in DWARF order? Its some haphazard index remapping? 28 => 9?!
There was a problem hiding this comment.
Well it's the DWARF order that's out of whack. It's easier to handle that here than in both current and fromPosixSignalContext.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.