Attempt to fix the packed struct problem #3745
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nment in packed structs.
|
I'm narrowing down the code in the test suite |
|
Okay, only two tests break with this pull request. |
|
Is already said in IRC, i withdraw this pull request, but leave it open for you to merge the tests into master. |
|
I added the test cases to #3133 (comment) and will be sure to cover them. Apologies for the delay in getting to this issue. I do have #3133 and associated bug reports marked as high priority for this release cycle. I know it's particularly important for your use cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix the packed struct problem (#2627, #3651) by removing ABI alignment in packed structs.
This crashes right now with an assertion in analyze.zig:9051 as the packed struct is smaller than it's alignment.
The code was still tested with
bin/zig build test -Dskip-release -Dskip-libc -Dskip-non-native, but withouttest/stage1/behaviour/struct.zig(which introduces the crash)