Use self hosted translate-c for cImport #3973

Vexu · 2019-12-22T21:23:26Z

Closes #1964

andrewrk · 2019-12-22T21:26:16Z

oh my god this is so beautiful

src-self-hosted/llvm.zig

lib/std/zig/ast.zig

daurnimator · 2019-12-26T22:09:18Z

test/translate_c.zig

@@ -21,9 +21,9 @@ pub fn addCases(cases: *tests.TranslateCContext) void {
    , &[_][]const u8{
        \\pub export fn foo() void {
        \\    var a: c_int = undefined;
-        \\    var b: u8 = @as(u8, 123);
+        \\    var b: u8 = @intCast(u8, 123);


Wouldn't we prefer @as?

Yes, but there seem to be some places @intCast is required and I'm not sure they can be done separately.

frmdstryr · 2019-12-27T14:40:11Z

I added the macro changes from #3984 in 17319ba, it'd be nice to merge those into this.

@daurnimator

Thanks @daurnimator

daurnimator · 2019-12-29T15:53:50Z

zig translate-c fail.zig on an empty file fail.zig results in a crash. (it doesn't make sense to pass a .zig file to translate-c, but I wasn't expecting a crash!)

- fix use of undefined value - fix parenexprclass result not being suppressed - add an error and a TODO for access of an anonymous field

frmdstryr · 2019-12-29T19:14:53Z

Thanks for merging.

If you're looking for more source to test with I've been trying to convert the stm32h7 headers.

One other issue is things like #define __IO volatile gets translated as pub const __IO = @"volatile"; when it should be replacing the types where it's used. I haven't looked at how to fix this yet..

Also it'd be nice to be able to retain comments and the order since currently converting makes them practically unreadable.

Vexu · 2019-12-29T19:55:50Z

One other issue is things like #define __IO volatile gets translated as pub const __IO = @"volatile"; when it should be replacing the types where it's used. I haven't looked at how to fix this yet..

Not sure what you mean here. If you want to use __IO as a replacement for the volatile keyword then that's not possible in Zig.

Also it'd be nice to be able to retain comments

Might be possible but low priority.

and the order

Order of what?

frmdstryr · 2019-12-29T22:12:41Z

Not sure what you mean here. If you want to use __IO as a replacement for the volatile keyword then that's not possible in Zig.

Oh sorry, I don't want to use __IO in place of volatile in zig. I want to be able to translate-c code which does this (ex) and have the keywords properly translated.

Order of what?

Order of which macros, functions, etc are defined. For example stm32h743xx.h currently translates to stm32h743xx.zig which seems to be in a completely random order (this was done with translate-c not translate-c-2 but they both do this). This is also a low priority.

andrewrk · 2019-12-29T22:36:40Z

Order of which macros, functions, etc are defined. For example stm32h743xx.h currently translates to stm32h743xx.zig which seems to be in a completely random order (this was done with translate-c not translate-c-2 but they both do this). This is also a low priority.

Yeah this is planned, but not a requirement to replace translate-c with the self-hosted version.

andrewrk · 2019-12-29T22:38:28Z

One other issue is things like #define __IO volatile gets translated as pub const __IO = @"volatile"; when it should be replacing the types where it's used. I haven't looked at how to fix this yet..

The translation of the macro is correct. What you're looking for is support for translating volatile things, which is a different topic than macros. The feature you're looking for is independent of whether someone uses __IO or directly uses the volatile keyword.

daurnimator · 2019-12-30T01:05:43Z

Errors don't seem to get reported well: if the clang invocation doesn't work, then we only report "C import failed". To get the actual error I have to use --verbose-cc and then run the clang command line myself.

andrewrk · 2019-12-30T05:01:35Z

The best way to troubleshoot with the self hosted version is to use --verbose-cimport and then open the translated zig code file in a text editor. The errors will be comments inline with the translated code.

daurnimator · 2019-12-30T05:11:34Z

The best way to troubleshoot with the self hosted version is to use --verbose-cimport and then open the translated zig code file in a text editor. The errors will be comments inline with the translated code.

That of course is only available if the cimport succeeded (which is not the case in the scenario above).

andrewrk · 2019-12-30T05:25:19Z

Oh I see, C compilation errors. That is a regression that I would like to rectify before merging this.

frmdstryr · 2019-12-30T14:35:31Z

I added support for #4006 to the tokenizer in https://github.com/Vexu/zig/compare/stage-2-cimport...frmdstryr:translate-c-macro-stringify-concat?expand=1

Not sure what's the best way to integrate it into translate-c.

andrewrk · 2019-12-31T21:58:17Z

I started working on merging this in the branch Vexu-stage-2-cimport.

andrewrk · 2020-01-01T02:13:37Z

Progress: the Vexu-stage-2-cimport branch is now passing all the tests for macOS as well as Linux. Next up: Windows.

Vexu · 2020-01-01T08:08:05Z

Re: 42945a2
Parameter names were being mangled unconditionally for a reason.

int foo(int bar) {
    bar = 2;
}
int bar = 4;

no longer produces valid zig as bar is being redeclared

pub export fn foo(arg_bar: c_int) c_int {
    var bar = arg_bar;
    bar = 2;
}
pub export var bar: c_int = 4;

andrewrk · 2020-01-01T18:09:04Z

Ah, thanks for pointing that out. I think we're going to need 2 passes over the clang AST unit. Once to determine all the names in the global namespace, and then a second one to actually do the translation. I'm on it.

andrewrk · 2020-01-01T19:46:37Z

I opened the branch as a pull request in #4025, let's continue efforts there. (pull requests can be filed against branches other than master)

Vexu commented Dec 22, 2019

View reviewed changes

src-self-hosted/llvm.zig Show resolved Hide resolved

Vexu force-pushed the stage-2-cimport branch 2 times, most recently from b022863 to 913f7cc Compare December 23, 2019 07:47

daurnimator reviewed Dec 26, 2019

View reviewed changes

lib/std/zig/ast.zig Show resolved Hide resolved

daurnimator reviewed Dec 26, 2019

View reviewed changes

FireFox317 mentioned this pull request Dec 27, 2019

Translate-C changes #3984

Closed

This comment has been minimized.

Sign in to view

daurnimator mentioned this pull request Dec 29, 2019

Assertion hit in clang::QualType::getCommonPtr() #3754

Closed

This comment has been minimized.

Sign in to view

Vexu added 4 commits December 29, 2019 11:04

use self hosted translate-c for cimports

fceda07

fix translate-c taking ages

3f7bab7

fix stage2 build

1a3633d

translate-c-2 use intCast in most places

59cc707

Vexu force-pushed the stage-2-cimport branch 2 times, most recently from b1a7d04 to a175454 Compare December 29, 2019 11:27

translate-c fix bugs

f5e7d2d

Thanks @daurnimator

Vexu force-pushed the stage-2-cimport branch from a175454 to f5e7d2d Compare December 29, 2019 12:02

This comment has been minimized.

Sign in to view

translate-c-2 fix assertion failure rendering do while

621629e

This comment has been minimized.

Sign in to view

Vexu and others added 2 commits December 29, 2019 19:23

translate-c-2 bug fixes

55348c9

- fix use of undefined value - fix parenexprclass result not being suppressed - add an error and a TODO for access of an anonymous field

Add macro ops

fcc82a2

frmdstryr and others added 3 commits December 29, 2019 19:50

Cleanup c_tokenizer.zig tests

6df9e9f

update c_tokenzier tests to new api

ca21161

translate-c-2 macro comparision ops

950eb81

frmdstryr mentioned this pull request Dec 31, 2019

Support stringize and concat in translate-c #4006

Closed

andrewrk mentioned this pull request Jan 1, 2020

Use self hosted translate-c for cImport #4025

Merged

5 tasks

andrewrk closed this Jan 1, 2020

Vexu deleted the stage-2-cimport branch January 2, 2020 09:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use self hosted translate-c for cImport #3973

Use self hosted translate-c for cImport #3973

Vexu commented Dec 22, 2019

andrewrk commented Dec 22, 2019

daurnimator Dec 26, 2019

Vexu Dec 26, 2019

frmdstryr commented Dec 27, 2019 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

daurnimator commented Dec 29, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

frmdstryr commented Dec 29, 2019

Vexu commented Dec 29, 2019

frmdstryr commented Dec 29, 2019

andrewrk commented Dec 29, 2019

andrewrk commented Dec 29, 2019

daurnimator commented Dec 30, 2019

andrewrk commented Dec 30, 2019

daurnimator commented Dec 30, 2019

andrewrk commented Dec 30, 2019

frmdstryr commented Dec 30, 2019

andrewrk commented Dec 31, 2019

andrewrk commented Jan 1, 2020

Vexu commented Jan 1, 2020

andrewrk commented Jan 1, 2020

andrewrk commented Jan 1, 2020

Use self hosted translate-c for cImport #3973

Use self hosted translate-c for cImport #3973

Conversation

Vexu commented Dec 22, 2019

andrewrk commented Dec 22, 2019

daurnimator Dec 26, 2019

Choose a reason for hiding this comment

Vexu Dec 26, 2019

Choose a reason for hiding this comment

frmdstryr commented Dec 27, 2019 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

daurnimator commented Dec 29, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

frmdstryr commented Dec 29, 2019

Vexu commented Dec 29, 2019

frmdstryr commented Dec 29, 2019

andrewrk commented Dec 29, 2019

andrewrk commented Dec 29, 2019

daurnimator commented Dec 30, 2019

andrewrk commented Dec 30, 2019

daurnimator commented Dec 30, 2019

andrewrk commented Dec 30, 2019

frmdstryr commented Dec 30, 2019

andrewrk commented Dec 31, 2019

andrewrk commented Jan 1, 2020

Vexu commented Jan 1, 2020

andrewrk commented Jan 1, 2020

andrewrk commented Jan 1, 2020

frmdstryr commented Dec 27, 2019 •

edited

Loading