New allocator corrections #5734
Conversation
|
StackFallbackAllocator is also broken as of #5064. Perhaps it should be replaced by a generic fallback allocator which wraps |
| /// This allocator is used in front of another allocator and logs to the provided writer | ||
| /// on every call to the allocator. Writer errors are ignored. | ||
| /// If https://github.com/ziglang/zig/issues/2586 is implemented, this API can be improved. | ||
| pub fn LoggingAllocator(comptime OutStreamType: type) type { | ||
| pub fn LoggingAllocator(comptime WriterType: type) type { |
There was a problem hiding this comment.
This should be changed to use std.log facilities, and it no longer needs to be a generic type.
There was a problem hiding this comment.
Does that mean we won't be able to test the logging output anymore?
There was a problem hiding this comment.
we can add a "compare output" test case for it: https://github.com/ziglang/zig/blob/master/test/compare_output.zig
There was a problem hiding this comment.
This gave me another idea: #5738
There was a problem hiding this comment.
This should be changed to use std.log facilities
What to use?
log.notice, log.info, log.debug?
What scope? .loggingAllocator?
we can add a "compare output" test case for it
How? With log function in compare_output.zig?
|
stale draft, please re-open when it's ready for review |
No description provided.