GeneralPurposeAllocator: use std.log instead of std.debug.print #6012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`std.builtin.StackTrace` gains a `format` function. GeneralPurposeAllocator uses `std.log.err` instead of directly printing to stderr. Some errors are recoverable. The test runner is modified to fail the test run if any log messages of "err" or worse severity are encountered. self-hosted is modified to always print log messages of "err" severity or worse even if they have not been explicitly enabled. This makes GeneralPurposeAllocator available on the freestanding target.
daurnimator
reviewed
Aug 11, 2020
| ) !void { | ||
| var arena = std.heap.ArenaAllocator.init(std.heap.page_allocator); | ||
| defer arena.deinit(); | ||
| const debug_info = std.debug.getSelfDebugInfo() catch |err| { |
There was a problem hiding this comment.
Previously there wasn't anything about this structure that indicated it was a StackTrace for the current process (as opposed to a child process or something else).
Perhaps there should be an enum { CurrentProcess, OtherProcess }?
Alternatively, maybe we could save the buildid? Related: #3047
| ) !void { | ||
| var arena = std.heap.ArenaAllocator.init(std.heap.page_allocator); | ||
| defer arena.deinit(); | ||
| const debug_info = std.debug.getSelfDebugInfo() catch |err| { |
There was a problem hiding this comment.
Does debug_info need to be freed?
| const debug_info = std.debug.getSelfDebugInfo() catch |err| { | ||
| return writer.print("\nUnable to print stack trace: Unable to open debug info: {}\n", .{@errorName(err)}); | ||
| }; | ||
| const tty_config = std.debug.detectTTYConfig(); |
There was a problem hiding this comment.
Who says that this is being sent to a TTY? what if its being logged to a file? or syslog?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std.builtin.StackTracegains aformatfunction.GeneralPurposeAllocator uses
std.log.errinstead of directly printingto stderr. Some errors are recoverable.
The test runner is modified to fail the test run if any log messages of
"err" or worse severity are encountered.
self-hosted is modified to always print log messages of "err" severity
or worse even if they have not been explicitly enabled.
This makes GeneralPurposeAllocator available on the freestanding target.