std: Limit the read/write size on Darwin #6333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that the kernel won't read or write more than 0x7fffffff bytes in a single call, failing with EINVAL when trying to do so. Adjust the limit and curse whoever is responsible for this. Closes ziglang#6332
daurnimator
added
os-macos
standard library
|
Argh, the API supports short writes, they could have just written |
|
Nice to see such a fast fix! As an aside it is non trivial to build zig from source on OSX these days due to llvm shenanigans. Thanks! |
Yep. We'll get there. Unfortunately with LLVM as a dependency, they have the power to mess up our build. If this doesn't get worked out with the next release cycle then it may be worth promoting our bootstrap repository as the main way to get up and running. Here's hoping that LLVM 11 fixes all the problems introduced with LLVM 10. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that the kernel won't read or write more than 0x7fffffff
bytes in a single call, failing with EINVAL when trying to do so.
Adjust the limit and curse whoever is responsible for this.
Closes #6332
See also rust-lang/rust#38590 and python/cpython#9937, the man pages don't mention this limitation at all...