std: Introduce SemanticVersion data structure #6566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayschwa
added
the
standard library
3 tasks
jayschwa
changed the title
SemanticVersion data structure
Vexu
reviewed
Oct 5, 2020
jayschwa
force-pushed
the
semver-struct
branch
from
00d49da to
3d74b6c
Compare
This will parse, format, and compare version strings following the SemVer 2 specification. See: https://semver.org Updates ziglang#6466
jayschwa
force-pushed
the
semver-struct
branch
from
3d74b6c to
ef0d2a7
Compare
|
Okay, I think this is in decent shape and ready for review. One question I have for reviewers is what to do about |
kubkon
reviewed
Oct 26, 2020
Comment on lines
+284
to
+295
| fn testFmt(expected: []const u8, comptime template: []const u8, args: anytype) !void { | ||
| var buf: [100]u8 = undefined; | ||
| const result = try std.fmt.bufPrint(buf[0..], template, args); | ||
| if (std.mem.eql(u8, result, expected)) return; | ||
|
|
||
| std.debug.warn("\n====== expected this output: =========\n", .{}); | ||
| std.debug.warn("{}", .{expected}); | ||
| std.debug.warn("\n======== instead found this: =========\n", .{}); | ||
| std.debug.warn("{}", .{result}); | ||
| std.debug.warn("\n======================================\n", .{}); | ||
| return error.TestFailed; | ||
| } |
There was a problem hiding this comment.
What if we move it into std.testing and make it public? Would that make sense?
There was a problem hiding this comment.
Yes, that makes sense to me. I suppose I should do that in a separate PR.
jayschwa
added a commit
to jayschwa/zig
that referenced
this pull request
Oct 27, 2020
This will enable easier testing for custom formatting implementations. Motivated by copy-pasted code in PR ziglang#6566.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will parse, format, and compare version strings following the
SemVer 2 specification. See: https://semver.org
Updates #6466