Skip to content

Conversation

@marc3lsk
Copy link

@marc3lsk marc3lsk commented Jan 16, 2018

A lot of jsx-compatible frameworks support traditional "class" attribute. I find the code much nicer when class is used instead of className.

@zignd zignd merged commit c99f755 into zignd:master Feb 18, 2018
@patricklafrance
Copy link

patricklafrance commented Sep 25, 2018

It would be quite nice if the attributes would be configurable.

For example if you use the babel-react-css-module plugin, you end up applying your "local" css class to the styleName attribute

<div styleName="modal" className="ba b--light-gray"> {children} </div>

Another example if when applying a css class for the active state of the NavLink component:

<NavLink to={url} className="link" activeClassName="menu-link--active"> {text} </NavLink>

Thank you,

Patrick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants