Properly handle failures after connect, during startup #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puddly
force-pushed
the
puddly/bellows-reconnect-fix
branch
from
0c6987d to
84a2e3b
Compare
Codecov Report
@@ Coverage Diff @@
## dev #483 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 51 51
Lines 4253 4262 +9
=======================================
+ Hits 4250 4259 +9
Misses 3 3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
startupinternally calleddisconnectin the event of a failure after connect but during initialization.disconnectcancels the reconnect task.This can be replicated by yanking out a USB coordinator once to get bellows to start reconnecting, and then yanking it out halfway through startup. This problem does not really affect USB coordinators though: if their serial port is present, they probably will work. Only networked coordinators really end up in a situation where the TCP connection succeeds but the port is unusable.
home-assistant/core#75292