Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace asyncio.wait_for with asyncio.timeout #546

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

puddly
Copy link
Contributor

@puddly puddly commented Apr 5, 2023

See zigpy/zigpy#1187.

This has the side effect of making ezsp.Protocol.command an async function instead of a sync function returning a future.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a1bcb88) 99.71% compared to head (962acc2) 99.71%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #546   +/-   ##
=======================================
  Coverage   99.71%   99.71%           
=======================================
  Files          61       61           
  Lines        4567     4581   +14     
=======================================
+ Hits         4554     4568   +14     
  Misses         13       13           
Impacted Files Coverage Δ
bellows/ezsp/__init__.py 99.13% <100.00%> (+0.01%) ⬆️
bellows/ezsp/protocol.py 97.24% <100.00%> (+0.07%) ⬆️
bellows/uart.py 100.00% <100.00%> (ø)
bellows/zigbee/application.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@puddly puddly merged commit 07b24f9 into zigpy:dev Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants