Reuse ZDO Initializers to create Endpoint objects on EZSP device #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #599 +/- ##
==========================================
- Coverage 99.75% 99.73% -0.02%
==========================================
Files 74 74
Lines 4966 4985 +19
==========================================
+ Hits 4954 4972 +18
- Misses 12 13 +1 ☔ View full report in Codecov by Sentry. |
|
Not sure what to do about codecov here; the endpoint initializer is async but the application fixture looks to be synchronous and everywhere. Happy to fix it, but I'll need a little handholding. |
This way if we need a reference to one we can grab it in a way we expect
|
I used this patch on the green power test net for a couple days and everything seems 100%. Thanks again for the cleanup job. |
|
You love to see it. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need access to a real GP
Clustertype for parsing the incoming frames, but EZSP doesn't support polling the device for current endpoints. Instead, reuse the old ZDO initializers and assume the device state matches the requested ZDO descriptors.