-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source routing fixes #626
Source routing fixes #626
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #626 +/- ##
==========================================
+ Coverage 99.13% 99.16% +0.02%
==========================================
Files 50 50
Lines 3456 3459 +3
==========================================
+ Hits 3426 3430 +4
+ Misses 30 29 -1 ☔ View full report in Codecov by Sentry. |
Applied this fix on my production setup. Unfortunately, I'm still seeing "missing routes" when testing 7 minutes after rebooting HA (just unable to toggle certain lights). I'll do more testing later. |
I have a branch somewhere where I was trying to manually send a MTOR request right after startup. Wonder if that is worth exploring more. |
dev...dmulcahey:bellows:dm/refresh-routes dev...dmulcahey:bellows:dm/improve-source-routing looks like I had 2 branches out there.... maybe some combo of this + tweaking will help. I never got too far w/ testing. |
I've implemented "dumb" source routing as a firmware extension. Alternate branches:
Network startup and mass command sending is now fast 😄 |
Two fixes:
setSourceRoute
is a no-op in EZSPv9 and above, the command does nothing. There is currently no known way to send packets with a specific source route in these EZSP versions. MaybeemberOverrideAppendSourceRouteHandler
can help if we create a custom XNCP command to maintain a temporary table of source routes per NWK address?CC @TheJulianJES