Disable XNCP MEMBER_OF_ALL_GROUPS on current firmwares
#658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #658 +/- ##
=======================================
Coverage 99.20% 99.20%
=======================================
Files 51 51
Lines 3649 3654 +5
=======================================
+ Hits 3620 3625 +5
Misses 29 29 ☔ View full report in Codecov by Sentry. |
TheJulianJES
approved these changes
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that I'm not able to see multicast group packets anymore on current firmware builds, even though this feature worked in testing. The rebase and project restructure may have disabled something.
Until this is fixed and new firmwares are released, we should revert back to the old behavior even if this feature flag is advertised. Otherwise, group traffic is no longer seen by the coordinator at all.