Fix invalid uniqueness constraint on unique_id #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #159 +/- ##
==========================================
- Coverage 95.69% 95.68% -0.02%
==========================================
Files 61 61
Lines 9270 9270
==========================================
- Hits 8871 8870 -1
- Misses 399 400 +1 ☔ View full report in Codecov by Sentry. |
puddly
reviewed
Aug 10, 2024
TheJulianJES
approved these changes
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oh boy... where to start...
fixes: #157
related: home-assistant/core#123387
Back story
An incorrect assumption was made when converting ZHA to a lib that the
unique_idof an entity in HA was globally unique. This is not the case.unique_idis only unique per platform. This caused unique id clashes that can be seen as detailed in the linked issues.Fix
To fix the issue the
platform_entitiesdict is now keyed by a tuple: (platform, unique_id) and all areas that leverage the dict are updated to account for the change.