Add more Inovelli blue switch entities

[tleydxdy]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.92%. Comparing base (cde2148) to head (b996deb).
Report is 7 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #203      +/-   ##
==========================================
+ Coverage   95.89%   95.92%   +0.02%     
==========================================
  Files          61       61              
  Lines        9413     9464      +51     
==========================================
+ Hits         9027     9078      +51     
  Misses        386      386              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dmulcahey]

Are these supported for all devices?

[tleydxdy]

Seems like the Dimming mode option is only for VZM31-SN and VZM36, the rest are in all three device's parameter table.

[dmulcahey]

Seems like the Dimming mode option is only for VZM31-SN and VZM36, the rest are in all three device's parameter table.

We should restrict those to the models they apply to then

[dmulcahey]

We also need to make sure the attributes are already merged in the mfg cluster in quirks before this can be merged.

We really should migrate all of these to v2 quirks so it’s all in one spot at some point

[tleydxdy]

do you mean these? https://github.com/zigpy/zha-device-handlers/blob/acecf704f2b253c9297d901eed8909dbd589ea97/zhaquirks/inovelli/__init__.py#L212 sorry I'm very new to this :)

[dmulcahey]

do you mean these? https://github.com/zigpy/zha-device-handlers/blob/acecf704f2b253c9297d901eed8909dbd589ea97/zhaquirks/inovelli/__init__.py#L212 sorry I'm very new to this :)

If they are common across all devices they go in the base class: https://github.com/zigpy/zha-device-handlers/blob/acecf704f2b253c9297d901eed8909dbd589ea97/zhaquirks/inovelli/__init__.py#L94

Otherwise they go in the appropriate extension

[tleydxdy]

yes, all these attributes are already there.

[puddly]

We should start migrating the Inovelli attributes in the quirk to the new Zigpy format, this will keep enums like this out of ZHA:

class LeadingOrTrailingEdge(t.enum8):
    LeadingEdge = 0x00
    TrailingEdge = 0x01


class InovelliVZM31SNCluster(CustomCluster):
    name = "InovelliVZM31SNCluster"

    class AttributeDefs(BaseAttributeDefs):
        """Attribute definitions."""
        ...

        leading_or_trailing_edge = ZCLAttributeDef(
            id=0x001A,
            type=LeadingOrTrailingEdge,
            zcl_type=DataTypeId.bool, # It's really a bool on the device
            is_manufacturer_specific=True,
        )

        ...