Remove defaulting of translation_key
#251
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of changes related to: zigpy/zigpy#1488
Proposed change
translation_key
no longer defaults toattribute_name
orcommand_name
.There's more information in the linked zigpy PR below on why this should be the case.
Additional information
Somewhat requires this zigpy PR to ensure
translation_key
ordevice_class
is provided for a proper name:fallback_name
and addtranslation_key
validation zigpy#1488Requires for tests to pass:
translation_key
andfallback_name
to tests #252I wanted to keep these changes separate from #252, as the changes are only semi-related.