Convert ZCL attributes from strings when writing #267
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #267 +/- ##
==========================================
+ Coverage 96.33% 96.49% +0.15%
==========================================
Files 61 61
Lines 9397 9420 +23
==========================================
+ Hits 9053 9090 +37
+ Misses 344 330 -14 ☔ View full report in Codecov by Sentry. |
|
Hi there - what's needed to push this one forward, as I'm struggling with broken device settings that would be resolved by this? Happy to help out if there's anything I can do :-) |
|
Hi! I am also having problems changing device settings. I have Tuya TZE204_qasjif9e and I can't change its parameters. Any news on enabling your fix? Write if I can help with testing :) |
|
I've not had time to write unit tests for this change so if you'd like to see it merged, 100% test coverage would be nice 😄 |
|
Love to help, but I’m not that familiar with the unit test system in use - if you’ve got a hint as to where to get started I’ll have a look though! :-) |
Maybe you can look at the current tests: |
puddly
force-pushed
the
puddly/zcl-attribute-writing-conversion
branch
from
6c08089 to
28476b3
Compare
* Convert ZCL attributes when writing * Handle bytes too * Add some unit tests * Address review comments Signed-off-by: Gilles DOFFE <g.doffe@gmail.com> Co-authored-by: Matthéo PERELLE <mattheo.perelle@gmail.com>
When writing attributes via the ZCL cluster management dialog, strings aren't currently converted into their correct type. I believe this is a regression.
We'll need to figure out a generic way to do string conversion for complex types, like arrays and structs.