Correct Sonoff TRVZB local temperature calibration min/max

[fgsch]

From Koenkk/zigbee-herdsman-converters#8214 via zigpy/zha-device-handlers#3358 (comment).

[tr4nt0r]

I think the step should also be 0.1

[fgsch]

@tr4nt0r, can you elaborate on why you think so? The original change uses 0.2.

[tr4nt0r]

I can write to the local_temperature_calibration attribute directly and it takes any integer value without any problems. Also how would it otherwise be possible to set a value of +12.7

[fgsch]

The max and min don't necessarily imply those are the values you can use; they correspond to the range for this type -128..127 (int8) before applying the multiplier.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.33%. Comparing base (11cf9ba) to head (3efa11f).
Report is 1 commits behind head on dev.

Additional details and impacted files

@@           Coverage Diff           @@
##              dev     #300   +/-   ##
=======================================
  Coverage   96.33%   96.33%           
=======================================
  Files          61       61           
  Lines        9388     9388           
=======================================
  Hits         9044     9044           
  Misses        344      344           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests

[TheJulianJES]

I think we could increase the step size if we wanted. I'd guess 0.2 was originally chosen, as it's easier doing 0.2°C steps when moving the slider in the HA frontend.

I'll merge this for now, as Z2M also uses step size 0.2 Feel free to open a separate PR if you'd prefer the smaller step size.
Does HA also limit the values to the step size when entered manually?

[TheJulianJES]

Thanks!

[tr4nt0r]

I think we could increase the step size if we wanted. I'd guess 0.2 was originally chosen, as it's easier doing 0.2°C steps when moving the slider in the HA frontend.

I'll merge this for now, as Z2M also uses step size 0.2 Feel free to open a separate PR if you'd prefer the smaller step size. Does HA also limit the values to the step size when entered manually?

@TheJulianJES if the number entity is used, Home Assistant validates the inputs and allows only the values within min/max and I think it also the step is validated, but I'm not 100% sure about that right now. Currently the entity for the offset has a step of 0.1 so it would change with the update. Having a step of 0.1 would make it easier when calculating the offsets via automation.

[TheJulianJES]

Currently the entity for the offset has a step of 0.1

Ah, the ZCL entity indeed has a 0.1 step. I've only looked at the Sonoff one before. We should probably change this one then.

[fgsch]

@TheJulianJES Ok, if a 0.1 step is the norm, I can open a PR to do this.

[TheJulianJES]

See:

• Adjust step to 0.1 for Sonoff thermostat calibration #304
• Use NumberMode.BOX for local temperature calibration #306