Replace deprecated add_to_registry_v2 in tests
#361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheJulianJES
added
code quality
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #361 +/- ##
==========================================
- Coverage 96.58% 96.56% -0.03%
==========================================
Files 61 61
Lines 9499 9499
==========================================
- Hits 9175 9173 -2
- Misses 324 326 +2 ☔ View full report in Codecov by Sentry. |
TheJulianJES
commented
Jan 26, 2025
There was a problem hiding this comment.
Hmm, this does reduce coverage slightly, as this was the only test that used add_to_registry_v2: https://app.codecov.io/gh/zigpy/zha/pull/361/indirect-changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace deprecated
add_to_registry_v2in tests