-
Notifications
You must be signed in to change notification settings - Fork 18
Don't fail on energy scan with legacy modules #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks! It would be nice to use a more specific exception than |
a44de4f
to
1afd02b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #166 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 780 784 +4
=========================================
+ Hits 780 784 +4 ☔ View full report in Codecov by Sentry. |
While checking your suggestion, I have noticed that the actual error is slightly different, it's not an unknown command but invalid parameter. |
Superseded by #168. The command is supported. This PR is not needed. |
Reopen for home-assistant/core#103208 (comment) |
Once #169 is merged, I will update this PR to use a more specific exception. |
8c062bc
to
0b0abbf
Compare
Done, updated and rebased. |
Fixes home-assistant/core#103208
If we receive the
RuntimeError
exeption onED
command, return zero energy scanning results instead of raising the exception.