Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mypy and more flake checks #138

Merged
merged 5 commits into from
Mar 1, 2022
Merged

Conversation

mdeweerd
Copy link
Contributor

No description provided.

@puddly
Copy link
Collaborator

puddly commented Mar 1, 2022

Thank you!

I've submitted a PR to your fork (mdeweerd#1) that fixes the remaining issues preventing this from being merged.

puddly and others added 3 commits March 1, 2022 13:45
@codecov-commenter
Copy link

Codecov Report

Merging #138 (fbc9fe8) into dev (515f4a1) will decrease coverage by 0.07%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #138      +/-   ##
==========================================
- Coverage   98.66%   98.59%   -0.08%     
==========================================
  Files          44       44              
  Lines        3907     3918      +11     
==========================================
+ Hits         3855     3863       +8     
- Misses         52       55       +3     
Impacted Files Coverage Δ
zigpy_znp/api.py 96.81% <84.21%> (-0.74%) ⬇️
zigpy_znp/tools/common.py 100.00% <100.00%> (ø)
zigpy_znp/types/basic.py 100.00% <100.00%> (ø)
zigpy_znp/types/commands.py 100.00% <100.00%> (ø)
zigpy_znp/types/cstruct.py 100.00% <100.00%> (ø)
zigpy_znp/types/named.py 100.00% <100.00%> (ø)
zigpy_znp/utils.py 100.00% <100.00%> (ø)
zigpy_znp/zigbee/application.py 95.85% <100.00%> (ø)
zigpy_znp/znp/security.py 95.18% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 515f4a1...fbc9fe8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants