-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump up dependencies on pyserial and pyserial-asyncio #50
Conversation
Bump up dependencies on pyserial and pyserial-asyncio for projects other projects that use this library but are not Home Assistant. Adminiuga did the same dependency version bump for Home Assistant in home-assistant/core#44089 pyserial-asyncio depends on pyserial and this bumps pyserial-asyncio to 0.5 version release and pyserial to 3.5 version release. https://github.com/pyserial/pyserial-asyncio/releases/tag/v0.5 https://github.com/pyserial/pyserial/releases/tag/v3.5
Codecov Report
@@ Coverage Diff @@
## dev #50 +/- ##
==========================================
- Coverage 99.14% 99.11% -0.04%
==========================================
Files 37 37
Lines 3169 3169
==========================================
- Hits 3142 3141 -1
- Misses 27 28 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zigpy-znp doesn't depend on a specific version of these packages so can you change the ==
to >=
?
I'm thinking it is just better to leave it as is, without any specific versioning??? There was nothing new in 3.5 or 0.5 which any of the radio lib requires. For non ZHA related projects, it would install the latest version anyway. For ZHA it is just better to control it from one place -- ZHA, since there are other integrations which pin pyserial and pyserial-asyncio, and pinning like in this PR would break compatibility with HA and cause those running HA core issues |
I agree. Python doesn't install per-package dependencies so as long as some upstream library (i.e. ZHA) requires specific pyserial-asyncio and pyserial features, zigpy-znp will work with them. The only real change that I'm aware of is pyserial/pyserial-asyncio#56, but apparently the new release broke Windows support: pyserial/pyserial-asyncio#69. May want to wait a few weeks to see if this report is valid and if other breakage occurs. |
For reference, here are all of the changes: pyserial/pyserial-asyncio@v0.4...v0.5 Have you tested these new package versions under load? I'll have to do this with zigpy-znp. |
running in my prod for a few days. haven't noticed anything abnormal, but it is well below heavy load. |
Change from == to >= for pyserial 3.5 and pyserial-asyncio 0.5
Changed from == to >= for pyserial 3.5 and pyserial-asyncio 0.5 |
Did the PR home-assistant/core#44089 not in effect pin these to specific versions pyserial and pyserial-asyncio in Home Assistant? Should maybe that be changed from |
Bump up dependencies on pyserial and pyserial-asyncio for projects other projects that use this library but are not Home Assistant.
Adminiuga did the same dependency version bump for Home Assistant in home-assistant/core#44089
pyserial-asyncio depends on pyserial and this bumps pyserial-asyncio to 0.5 version release and pyserial to 3.5 version release.
https://github.com/pyserial/pyserial-asyncio/releases/tag/v0.5
https://github.com/pyserial/pyserial/releases/tag/v3.5